Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alpine based Variant Store Docker image [VS-648] #8044

Merged
merged 10 commits into from
Oct 6, 2022
Merged

Alpine based Variant Store Docker image [VS-648] #8044

merged 10 commits into from
Oct 6, 2022

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Oct 3, 2022 •
edited
Loading

@codecov
Copy link

codecov bot commented Oct 3, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@c7df760). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             ah_var_store     #8044   +/-   ##
================================================
  Coverage                ?   49.580%           
  Complexity              ?     25392           
================================================
  Files                   ?      2173           
  Lines                   ?    165004           
  Branches                ?     17792           
================================================
  Hits                    ?     81809           
  Misses                  ?     77736           
  Partials                ?      5459

rsasch
rsasch approved these changes Oct 3, 2022
View reviewed changes
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trusting that you will add a link to a successful integration run

koncheto-broad
koncheto-broad approved these changes Oct 6, 2022
View reviewed changes
Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with Miguel. Looks solid

@mcovarr mcovarr merged commit 2ae759b into ah_var_store Oct 6, 2022
@mcovarr mcovarr deleted the vs_648_alpine branch October 6, 2022 15:04
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koncheto-broad koncheto-broad koncheto-broad approved these changes

@rsasch rsasch rsasch approved these changes

@RoriCremer RoriCremer Awaiting requested review from RoriCremer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcovarr @rsasch @koncheto-broad